Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15380 )
Change subject: KUDU-3070 skip open block manager ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/15380/12/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_manager.h: http://gerrit.cloudera.org:8080/#/c/15380/12/src/kudu/fs/fs_manager.h@134 PS12, Line 134: // Whether or not skip opening the block manager. Nit: "Whether or not to skip opening the block manager. FsManager operations that require the block manager will crash." http://gerrit.cloudera.org:8080/#/c/15380/12/src/kudu/fs/fs_manager.h@138 PS12, Line 138: }; Nit: add an extra empty line after this. http://gerrit.cloudera.org:8080/#/c/15380/12/src/kudu/fs/fs_manager.h@293 PS12, Line 293: return block_manager_.get(); Should DCHECK here as well. http://gerrit.cloudera.org:8080/#/c/15380/12/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/15380/12/src/kudu/tools/tool_action_local_replica.cc@289 PS12, Line 289: FsManager fs_manager(env, fs_opts); Should std::move(fs_opts). -- To view, visit http://gerrit.cloudera.org:8080/15380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaec03512086430a6270c458269da1cf996fd9c5 Gerrit-Change-Number: 15380 Gerrit-PatchSet: 12 Gerrit-Owner: wangning <1994wangn...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: wangning <1994wangn...@gmail.com> Gerrit-Comment-Date: Tue, 10 Mar 2020 06:20:25 +0000 Gerrit-HasComments: Yes
