Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15394 )

Change subject: KUDU-3050: recover from corrupt kerberos ccache
......................................................................


Patch Set 4:

> (5 comments)
 >
 > > > Patch Set 4:
 > > >
 > > > Might be https://krbdev.mit.edu/rt/Ticket/Display.html?id=8437
 > or
 > > similar. I don't see any evidence that Kudu is misusing the APIs.
 > > It looks like the memory is allocated in either krb5_cc_resolve()
 > > or krb5_cc_dup(), by tracing back from fcc_resolve.
 > >
 > > Try running the test with ASAN_OPTIONS=fast_unwind_on_malloc=0 in
 > > the environment. That should give you a more complete stack
 > trace.
 >
 > Should we call krb5_cc_end_seq_get() even if prior call to
 > krb5_cc_start_seq_get() returned an error?  Maybe, that's the
 > reason?
 >
 > I.e., maybe add
 > SCOPED_CLEANUP({krb5_cc_end_seq_get(g_krb5_ctx, ccache_, &cursor);
 > });
 >
 > before call to krb5_cc_start_seq_get().

Ah, most likely not the case.


--
To view, visit http://gerrit.cloudera.org:8080/15394
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d6e06c3ea65708896a6bf0134cc84838b3f1b58
Gerrit-Change-Number: 15394
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-Comment-Date: Wed, 11 Mar 2020 00:32:33 +0000
Gerrit-HasComments: No

Reply via email to