Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15398 )
Change subject: subprocess: maintain a thread for fork/exec ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15398/1/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/15398/1/src/kudu/subprocess/server.cc@109 PS1, Line 109: while (!closing_.WaitFor(MonoDelta::FromSeconds(60))) {} How about just closing_.Wait()? The latch already loops internally. -- To view, visit http://gerrit.cloudera.org:8080/15398 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I803b1613ef1a988df1da4c908c2c37e1fbbdcf81 Gerrit-Change-Number: 15398 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 11 Mar 2020 00:42:55 +0000 Gerrit-HasComments: Yes
