Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15405 )
Change subject: [build] Fix relocate_binaries_for_mini_cluster.py on Python 3 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15405/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15405/1//COMMIT_MSG@10 PS1, Line 10: by ignoring decode failures on string like objects. > Are such failures expected? If not, why not let the exception percolate up In Python 2 the objects are binary like, in Python 3 they are string like. It seems the most widely accepted way to handle this is to try and decode to get a string like oject and ignore the failure since the object is already string like. -- To view, visit http://gerrit.cloudera.org:8080/15405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I792edd867546315baa05b15c711c72f456bb5bd3 Gerrit-Change-Number: 15405 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 11 Mar 2020 16:08:08 +0000 Gerrit-HasComments: Yes
