Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15410 )
Change subject: [java] Fix checkstyle and spotbugs issues ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15410/4/java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java File java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java: http://gerrit.cloudera.org:8080/#/c/15410/4/java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/echo/TestEchoSubprocess.java@117 PS4, Line 117: // Suppress checkstyle VariableDeclarationUsageDistance warning. : // CHECKSTYLE:OFF > Seems like we could just as easily have moved the executor definition to L1 I tried that but the test failed, without investing much further I assumed sendRequestToPipe modified some static state or something. I can try again. -- To view, visit http://gerrit.cloudera.org:8080/15410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89c226da7a763991c5adacbc609710450535e26c Gerrit-Change-Number: 15410 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 11 Mar 2020 22:36:57 +0000 Gerrit-HasComments: Yes
