Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15423 )
Change subject: [java] use KuduTestHarness in TestConnectToCluster ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15423/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java: http://gerrit.cloudera.org:8080/#/c/15423/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestConnectToCluster.java@78 PS2, Line 78: assertEquals(harness.getMasterServers().size(), masterAddrs.length); I think this is guaranteed given the harness is providing `getMasterServers().size()` and `masterAddrs`. I would leave the hard coded 3 to ensure that this breaks if the harness ever changes to use 1 master in the future. -- To view, visit http://gerrit.cloudera.org:8080/15423 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia845b073d68380946e1b5e59c56508007a154702 Gerrit-Change-Number: 15423 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 13 Mar 2020 12:45:50 +0000 Gerrit-HasComments: Yes
