Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 )
Change subject: rpc: reduce context switches and receive calls ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15440/1/src/kudu/rpc/transfer.h File src/kudu/rpc/transfer.h: http://gerrit.cloudera.org:8080/#/c/15440/1/src/kudu/rpc/transfer.h@70 PS1, Line 70: faststring&& nit: why not pass by copy instead of explicitly r-value work? Seems like faststring has a move operator. http://gerrit.cloudera.org:8080/#/c/15440/1/src/kudu/rpc/transfer.h@73 PS1, Line 73: faststring* extra_4 nit: doc this? http://gerrit.cloudera.org:8080/#/c/15440/1/src/kudu/rpc/transfer.cc File src/kudu/rpc/transfer.cc: http://gerrit.cloudera.org:8080/#/c/15440/1/src/kudu/rpc/transfer.cc@104 PS1, Line 104: const int kExtraReadLength = kMsgLengthPrefixLength; nit: could be static? -- To view, visit http://gerrit.cloudera.org:8080/15440 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32c5e4d146c25be8e90665a0cb8385fcd017b15c Gerrit-Change-Number: 15440 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sun, 15 Mar 2020 07:42:39 +0000 Gerrit-HasComments: Yes
