Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15444 )

Change subject: [java] fix bug in getClosestServerInfo code
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/15444/1/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java
File java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java:

http://gerrit.cloudera.org:8080/#/c/15444/1/java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java@199
PS1, Line 199:       if (tabletServers.isEmpty()) {
> How about just an early return null here if tabletServers is empty? Functio
Done



--
To view, visit http://gerrit.cloudera.org:8080/15444
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4dc471b5044ea4b5bd6202ccd2a707d6e229ea0
Gerrit-Change-Number: 15444
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Mon, 16 Mar 2020 07:27:25 +0000
Gerrit-HasComments: Yes

Reply via email to