Hello Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/15420
to look at the new patch set (#3).
Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64
......................................................................
KUDU-3072 Add glog patch to support stacktrace for aarch64
According to the comments in glog-0.3.5/src/utilities.h,
there are three different ways we can try to get the stack trace:
1) The libunwind library
2) Our hand-coded stack-unwinder
3) The gdb unwinder
We use first way to get stack trace by default, the function
"GetStackTrace" is defined in stacktrace_libunwind-inl.h, but
it doesn't work for aarch64, this changes to use the
implementation of aarch64 which defined in
stacktrace_aarch64-inl.h no matter libunwind exist or not.
I have proposed a PR to google/glog:
github.com/google/glog/pull/529
Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
2 files changed, 153 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/20/15420/3
--
To view, visit http://gerrit.cloudera.org:8080/15420
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia8ca769b2bef5fa658d56d11b7ac9537fd9ca637
Gerrit-Change-Number: 15420
Gerrit-PatchSet: 3
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
