Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 )
Change subject: KUDU-3068 Add atomic operations for aarch64 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15455/1/src/kudu/gutil/atomicops-internals-arm64.h File src/kudu/gutil/atomicops-internals-arm64.h: PS1: > It base on https://github.com/protocolbuffers/protobuf/blob/3.5.x/src/googl Gotcha. Could you split this up into two commits then? - First commit that imports the pristine file from protobuf - Second commit that makes any Kudu-specific changes to it, and hooks it into atomicops.h. The second commit is the more interesting one to review, hence the desire to split it up. -- To view, visit http://gerrit.cloudera.org:8080/15455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b31cdfd1daacbe2fef614c74baf0fc825a39377 Gerrit-Change-Number: 15455 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <huangtianhua...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <huangtianhua...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Mar 2020 16:58:46 +0000 Gerrit-HasComments: Yes
