Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 )
Change subject: rpc: use a lighter weight completion for sync RPCs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15441/1/src/kudu/util/notification.h File src/kudu/util/notification.h: http://gerrit.cloudera.org:8080/#/c/15441/1/src/kudu/util/notification.h@82 PS1, Line 82: DCHECK_EQ(s, NOT_NOTIFIED_HAS_WAITERS); > Isn't it possible for this to be violated if two threads race in WaitForNot +1. -- To view, visit http://gerrit.cloudera.org:8080/15441 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b65cce8bd48ee7edf6b2d08e96d00681c32aa97 Gerrit-Change-Number: 15441 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 17 Mar 2020 21:06:49 +0000 Gerrit-HasComments: Yes
