Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15481 )
Change subject: [build] Skip builds with no functional changes ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/15481/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15481/4//COMMIT_MSG@9 PS4, Line 9: This patch introduces the option to skip builds in pre-commit when : the changes are in files or directories that do not impact the build : or test. > I appreciate the motivation behind this, but are you sure this is desirable I think the safest bet is to ignore things that are "safe" to ignore. Essentially target no false positives, but accept some false negatives. http://gerrit.cloudera.org:8080/#/c/15481/4//COMMIT_MSG@13 PS4, Line 13: This functionality is disabled by default but can be enabled on our Jenkins instance by setting `KUDU_ALLOW_SKIPPED_TESTS=1`. > Too long. Done http://gerrit.cloudera.org:8080/#/c/15481/4//COMMIT_MSG@17 PS4, Line 17: precomit > pre-commit Done http://gerrit.cloudera.org:8080/#/c/15481/4/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: http://gerrit.cloudera.org:8080/#/c/15481/4/build-support/jenkins/build-and-test.sh@96 PS4, Line 96: .dockerignore > Could add .gitignore and .ycm_extra_conf.py too. Done http://gerrit.cloudera.org:8080/#/c/15481/4/build-support/jenkins/build-and-test.sh@96 PS4, Line 96: examples > We build the C++ example in client-examples.sh, so we can't exclude the ent I will drop this directory then in case we choose to build other examples in the future as well. http://gerrit.cloudera.org:8080/#/c/15481/4/build-support/jenkins/build-and-test.sh@96 PS4, Line 96: grep -qvE "^\.dockerignore|^docker/|^docs/|^examples/|^kubernetes/|LICENSE\.txt|NOTICE\.txt|.*\.adoc|.*\.md"; then > Any way we could set this up with each entry on its own line? It'll be much I am not sure how to wrap this. FWIW we shouldn't be adjusting this too much. -- To view, visit http://gerrit.cloudera.org:8080/15481 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If56db6593ce7aa64b562a9fb277a337bffc7b532 Gerrit-Change-Number: 15481 Gerrit-PatchSet: 4 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Mar 2020 20:56:20 +0000 Gerrit-HasComments: Yes
