Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15433 )
Change subject: [java] use KuduTestHarness in TestSecurity ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15433/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java: http://gerrit.cloudera.org:8080/#/c/15433/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java@78 PS1, Line 78: cla = new CapturingLogAppender(); Given it's not used in every test, maybe just instantiate the appender in the tests where it's used? -- To view, visit http://gerrit.cloudera.org:8080/15433 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb9089a414f5aa2277779c57a07b41405d35d311 Gerrit-Change-Number: 15433 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 18 Mar 2020 22:01:26 +0000 Gerrit-HasComments: Yes
