Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15474 )
Change subject: metrics: replace kudu::Bind usage with lambdas in FunctionGauge ...................................................................... Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15474/2/src/kudu/consensus/consensus-test-util.h File src/kudu/consensus/consensus-test-util.h: http://gerrit.cloudera.org:8080/#/c/15474/2/src/kudu/consensus/consensus-test-util.h@39 PS2, Line 39: #include "kudu/gutil/bind.h" :( that this file has boost::bind, std::bind and kudu::Bind. Thanks for making an effort to pare this down. -- To view, visit http://gerrit.cloudera.org:8080/15474 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If60a0dabde1fde1465d73dd9e8edc244fc780c37 Gerrit-Change-Number: 15474 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 06:05:11 +0000 Gerrit-HasComments: Yes
