Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15488 )
Change subject: [util] KUDU-3067 add OpenStack metadata detector ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15488/1/src/kudu/util/cloud/instance_metadata.cc File src/kudu/util/cloud/instance_metadata.cc: http://gerrit.cloudera.org:8080/#/c/15488/1/src/kudu/util/cloud/instance_metadata.cc@189 PS1, Line 189: if (openstack.Init().ok()) { > So we'll need two curls to identify the common case of a bog-standard AWS i I could not find another way doing so that would seem reliable given current OpenStack Nova & AWS documentation. I considered checking HTTP response headers fields, but it's more fragile given it's not documented as a part of API, and there isn't a guarantee that OpenStack will not emulate response headers of EC2 servers as well. -- To view, visit http://gerrit.cloudera.org:8080/15488 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84cc6d155ab1fbd7b401f5349d292f46fcac3a34 Gerrit-Change-Number: 15488 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: liusheng <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 15:55:08 +0000 Gerrit-HasComments: Yes
