Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15483 )
Change subject: KUDU-3079 Add MiniRanger ...................................................................... Patch Set 10: (7 comments) http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.h File src/kudu/ranger/mini_ranger.h: http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.h@38 PS9, Line 38: explicit MiniRanger(std::string data_root) : > warning: single-argument constructors must be marked explicit to avoid unin Done http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.cc File src/kudu/ranger/mini_ranger.cc: http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.cc@55 PS9, Line 55: // TODO(abukor): Has some hardcoded values. > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.cc@56 PS9, Line 56: const string kInstallProperties = R"( > warning: 'kInstallProperties' is a static definition in anonymous namespace Done http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.cc@240 PS9, Line 240: const string kRangerAdminSiteTemplate = R"( > warning: 'kRangerAdminSiteTemplate' is a static definition in anonymous nam Done http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.cc@534 PS9, Line 534: const string kRangerAdminDefaultSiteTemplate = R"( > warning: 'kRangerAdminDefaultSiteTemplate' is a static definition in anonym Done http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.cc@1119 PS9, Line 1119: const string kCoreSiteTemplate = R"( > warning: 'kCoreSiteTemplate' is a static definition in anonymous namespace; Done http://gerrit.cloudera.org:8080/#/c/15483/9/src/kudu/ranger/mini_ranger.cc@1304 PS9, Line 1304: Status MiniRanger::CreateRangerConfigs(const string& config_string, const string& file_path) { > warning: method 'CreateRangerConfigs' can be made static [readability-conve Done -- To view, visit http://gerrit.cloudera.org:8080/15483 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15ab1eb8abe71c074c26b286073442882e101bc6 Gerrit-Change-Number: 15483 Gerrit-PatchSet: 10 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 19 Mar 2020 18:13:12 +0000 Gerrit-HasComments: Yes
