Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15502 )
Change subject: tserver: avoid spinlock in scanners hot path ...................................................................... Patch Set 1: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/15502/1//COMMIT_MSG Commit Message: PS1: Nice, I assumed it was the case that we ought to be using atomics more widely than spinlocks, but never tested it out for myself. Glad to hear you actually observed a difference. http://gerrit.cloudera.org:8080/#/c/15502/1/src/kudu/tserver/scanners.h File src/kudu/tserver/scanners.h: http://gerrit.cloudera.org:8080/#/c/15502/1/src/kudu/tserver/scanners.h@19 PS1, Line 19: #include <cstddef> Probably need to add <atomic> -- To view, visit http://gerrit.cloudera.org:8080/15502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If3c32e94ada847076580e20571440833a8544c57 Gerrit-Change-Number: 15502 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 19 Mar 2020 22:20:01 +0000 Gerrit-HasComments: Yes
