Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15503 )
Change subject: client: micro-optimize getters by outlining cold path ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15503/1/src/kudu/client/scan_batch.cc File src/kudu/client/scan_batch.cc: http://gerrit.cloudera.org:8080/#/c/15503/1/src/kudu/client/scan_batch.cc@243 PS1, Line 243: BadTypeStatus nit: maybe add a comment that we're explicitly out-lining here? This seems trivial enough that I can imagine a future dev unknowingly reverting this change. -- To view, visit http://gerrit.cloudera.org:8080/15503 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5838576b3e18cbe8e093bf1e9ce6418ce922de63 Gerrit-Change-Number: 15503 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Mar 2020 00:23:15 +0000 Gerrit-HasComments: Yes
