Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15506 )
Change subject: tablet: plumb delta stats into delta compaction outputs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15506/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15506/3//COMMIT_MSG@15 PS3, Line 15: I considered also plumbing stats into merge compactions, but opted not : to > I'm trying to conceptualize what happens to the delta stats of N REDO files Not sure I follow. We wouldn't be making sense of any pre-compaction delta stats. When we create new DRSs with the rolling DRSW, as we're writing, iterates through deltas for each row, and in doing so, generates new delta stats. Those delta stats could be passed to the resulting DeltaFileReaders. -- To view, visit http://gerrit.cloudera.org:8080/15506 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea2f28fb2905ddcc007c88ab80ae2185587400f0 Gerrit-Change-Number: 15506 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 20 Mar 2020 05:16:13 +0000 Gerrit-HasComments: Yes
