Andrew Wong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15436 )

Change subject: [ranger] fix incorrect authz enforcement in Ranger authz 
provider
......................................................................


Patch Set 8:

(2 comments)

I presume you tested this on a real cluster?

http://gerrit.cloudera.org:8080/#/c/15436/7/src/kudu/ranger/ranger_client.cc
File src/kudu/ranger/ranger_client.cc:

http://gerrit.cloudera.org:8080/#/c/15436/7/src/kudu/ranger/ranger_client.cc@20
PS7, Line 20: stdint
nit: We prefer <cstdint> in newer code.


http://gerrit.cloudera.org:8080/#/c/15436/7/src/kudu/ranger/ranger_client.cc@211
PS7, Line 211:
Remove.



--
To view, visit http://gerrit.cloudera.org:8080/15436
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I267aabc5f224ee7ceeffd6187785595dd6f16487
Gerrit-Change-Number: 15436
Gerrit-PatchSet: 8
Gerrit-Owner: Hao Hao <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Hao Hao <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Fri, 20 Mar 2020 05:17:34 +0000
Gerrit-HasComments: Yes

Reply via email to