Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/15535 )
Change subject: [KUDU-3085] Create Scala/SBT integration test example. ...................................................................... Patch Set 1: (7 comments) Thanks for the review! http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc File examples/scala/sbt-int-test-example/README.adoc: http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@19 PS1, Line 19: :author: Brian McDevitt > Can you remove these lines? We generally don't attribute authorship in Apac Done http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@47 PS1, Line 47: addSbtPlugin("io.phdata" % "sbt-os-detector" % "0.2.0") //<3> > Can you link to the source for this? It's linked via the <3> description on line 51. http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@63 PS1, Line 63: resolvers += "Cloudera" at "https://repository.cloudera.com/artifactory/cloudera-repos";, > You shouldn't need the Cloudera repos here. Done http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/README.adoc@71 PS1, Line 71: scalafmtVersion := "1.2.0" > Maybe remove scalafmt stuff to keep the example minimal? Done http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/build.sbt File examples/scala/sbt-int-test-example/build.sbt: PS1: > Same comments from the readme apply here. Done http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/project/plugins.sbt File examples/scala/sbt-int-test-example/project/plugins.sbt: http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/project/plugins.sbt@21 PS1, Line 21: addSbtPlugin("com.lucidchart" % "sbt-scalafmt-coursier" % "1.12") > Is coursier required? No; removed. http://gerrit.cloudera.org:8080/#/c/15535/1/examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/Movie.scala File examples/scala/sbt-int-test-example/src/main/scala/org/apache/kudu/scala/examples/Movie.scala: PS1: > Is this used anywhere? Maybe remove it? Done -- To view, visit http://gerrit.cloudera.org:8080/15535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia0ac7abef89c70c5989bd6cb894c8989ed167ec8 Gerrit-Change-Number: 15535 Gerrit-PatchSet: 1 Gerrit-Owner: Brian McDevitt <[email protected]> Gerrit-Reviewer: Brian McDevitt <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 23 Mar 2020 19:54:57 +0000 Gerrit-HasComments: Yes
