Grant Henke has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/15530 )

Change subject: [docker] Make the build image more useful for development
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/15530/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/15530/1//COMMIT_MSG@10
PS1, Line 10: includes
> nit: replace with 'contains' since there is also 'including'
Done


http://gerrit.cloudera.org:8080/#/c/15530/1//COMMIT_MSG@11
PS1, Line 11: sentry
> nit: Sentry ?
Done


http://gerrit.cloudera.org:8080/#/c/15530/1//COMMIT_MSG@13
PS1, Line 13: Replaced ntp with chrony
> Thank you for doing this!
Done


http://gerrit.cloudera.org:8080/#/c/15530/1//COMMIT_MSG@15
PS1, Line 15: edditing
> editing
Done


http://gerrit.cloudera.org:8080/#/c/15530/1//COMMIT_MSG@21
PS1, Line 21: hybrid_clock-test
> I'm working on this as well.  Have you started working on this already?
No, I haven't spent much time investigating.


http://gerrit.cloudera.org:8080/#/c/15530/1//COMMIT_MSG@28
PS1, Line 28: build the image
> Do you mind mentioning the OS/platform used for the build?
I have only used the default (xenial) so far, but this should work for all 
supported base OSs. I plan to test them all before the next release.



--
To view, visit http://gerrit.cloudera.org:8080/15530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1e4b463a440a3f76fb07425aebcbda2050b9917e
Gerrit-Change-Number: 15530
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 24 Mar 2020 04:17:24 +0000
Gerrit-HasComments: Yes

Reply via email to