Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15542 )
Change subject: [util] set CURLOPT_NOPROXY for EasyCurl ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h File src/kudu/util/curl_util.h: http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@123 PS1, Line 123: // A comma-separated list of host names to disable proxying request to This is fairly duplicative w.r.t. the documentation of set_noproxy. Could you cherry-pick the novel bits into that doc and drop this one? http://gerrit.cloudera.org:8080/#/c/15542/1/src/kudu/util/curl_util.h@127 PS1, Line 127: ussued issued -- To view, visit http://gerrit.cloudera.org:8080/15542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If767bfb28516acb06f6243945300f5a362b869f8 Gerrit-Change-Number: 15542 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 24 Mar 2020 06:56:50 +0000 Gerrit-HasComments: Yes
