Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15551 )
Change subject: [clock] hybrid_clock-test to run in different environments ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/15551/2/src/kudu/clock/hybrid_clock-test.cc File src/kudu/clock/hybrid_clock-test.cc: http://gerrit.cloudera.org:8080/#/c/15551/2/src/kudu/clock/hybrid_clock-test.cc@479 PS2, Line 479: ASSERT_TRUE(s.IsRuntimeError()) << s.ToString(); What value does this add? http://gerrit.cloudera.org:8080/#/c/15551/2/src/kudu/clock/hybrid_clock-test.cc@483 PS2, Line 483: ASSERT_TRUE(s.IsServiceUnavailable()) << s.ToString(); Likewise. http://gerrit.cloudera.org:8080/#/c/15551/2/src/kudu/clock/hybrid_clock-test.cc@505 PS2, Line 505: WARN_NOT_OK(clock.Init(), "clock initialization failed"); Maybe add a comment explaining why we're not ASSERTing here? -- To view, visit http://gerrit.cloudera.org:8080/15551 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id5cee9f4a32c18c50fe54c01c7ed81c7e93c5fa7 Gerrit-Change-Number: 15551 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 25 Mar 2020 04:37:32 +0000 Gerrit-HasComments: Yes
