Hello Andrew Wong, Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15559

to review the following change.


Change subject: rowblock: improve GetSelectedRows API
......................................................................

rowblock: improve GetSelectedRows API

The earlier commit used a boolean return value to indicate whether all
rows were selected, but as I used the API more, I found the code
somewhat confusing. This adds a wrapper class with appropriate getters
and error checking.

Change-Id: I34630c7bb854cca572ec081acbc05f3dac4db931
---
M src/kudu/common/rowblock-test.cc
M src/kudu/common/rowblock.cc
M src/kudu/common/rowblock.h
M src/kudu/common/wire_protocol.cc
4 files changed, 89 insertions(+), 33 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/59/15559/1
--
To view, visit http://gerrit.cloudera.org:8080/15559
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34630c7bb854cca572ec081acbc05f3dac4db931
Gerrit-Change-Number: 15559
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>

Reply via email to