Hello Tidy Bot, Andrew Wong, Kudu Jenkins, Adar Dembo, Grant Henke,

I'd like you to reexamine a change. Please visit


to look at the new patch set (#4).

Change subject: Add core algorithms for columnar serialization

Add core algorithms for columnar serialization

This adds the core of the columnar serialization code paths. Even though
we internally scan in a columnar fashion in the tablet server, sending
those columns across the wire isn't straightforward. We have two bits of
necessary processing:

1) the selection vector needs to be taken into account so we only send
back selected rows. This means we need to copy out the selected cells
and also copy out the selected bits from the null bitmap where relevant.
Doing the null bitmap portion efficiently with wide platform support
makes up a lot of this patch.

2) for the case of null values, we want to make sure we don't send
uninitialized memory (which might include secrets!) to the client. So we
need to zero out any cells where the corresponding non-null bitmap bit
is unset.

To keep the review manageable, this just adds some unit tests and all
the new code is initially "dead". Later commits will add the parts that
construct the full block of columns to be sent on the wire, hook this
into the tserver, etc.

Change-Id: I16f2993081aac54609aab4d8219ef0bf6c7708c2
M src/kudu/common/CMakeLists.txt
A src/kudu/common/columnar_serialization-test.cc
A src/kudu/common/columnar_serialization.cc
A src/kudu/common/columnar_serialization.h
A src/kudu/common/zp7.cc
A src/kudu/common/zp7.h
7 files changed, 835 insertions(+), 1 deletion(-)

  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/15556/4
To view, visit http://gerrit.cloudera.org:8080/15556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I16f2993081aac54609aab4d8219ef0bf6c7708c2
Gerrit-Change-Number: 15556
Gerrit-PatchSet: 4
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>

Reply via email to