Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15559 )
Change subject: rowblock: improve GetSelectedRows API ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/15559/2/src/kudu/common/rowblock.h File src/kudu/common/rowblock.h: http://gerrit.cloudera.org:8080/#/c/15559/2/src/kudu/common/rowblock.h@231 PS2, Line 231: bool all_selected() const { : return all_selected_; : } : : int num_selected() const { : return all_selected_ ? sel_vector_->nrows() : indexes_.size(); : } : : // Get the selected rows. : // : // NOTE: callers must check all_selected() first, and not use this : // function if all rows are selected. 'AsRowIndexes()' may be used instead. : const std::vector<uint16_t>& indexes() const { : DCHECK(!all_selected_); : return indexes_; : } : : const uint8_t* bitmap() const { : return sel_vector_->bitmap(); : } Are these useful outside of tests? If not, make add friend tests and make these private? Or will the be more publicly useful with your columnar patches? -- To view, visit http://gerrit.cloudera.org:8080/15559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34630c7bb854cca572ec081acbc05f3dac4db931 Gerrit-Change-Number: 15559 Gerrit-PatchSet: 2 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Andrew Wong <andrew.w...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 25 Mar 2020 22:49:22 +0000 Gerrit-HasComments: Yes
