Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15584 )
Change subject: env: add a fifo class ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/15584/3/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/15584/3/src/kudu/util/env_posix.cc@357 PS3, Line 357: if (f == -1) { : return Status::IOError(Substitute("Error opening for $0: $1", reason, filename)); > Done Not done? I see you've changed NewFifo but not DoOpen here. -- To view, visit http://gerrit.cloudera.org:8080/15584 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I23920457d695b84509937694daea53d61f445e27 Gerrit-Change-Number: 15584 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 30 Mar 2020 17:33:51 +0000 Gerrit-HasComments: Yes
