Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15600 )
Change subject: [util] Add special handling for nullptr in fast hash ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java File java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java: http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@a92 PS1, Line 92: > That wasn't the intent. Had that been the case, there would have been valid Ack http://gerrit.cloudera.org:8080/#/c/15600/1/java/kudu-client/src/main/java/org/apache/kudu/util/HashUtil.java@24 PS1, Line 24: // Constant imported from Apache Impala used to compute hash values for special cases. : // Constant obtained by taking lower bytes of generated UUID. > HASH_VAL_NULL is only 4 bytes though, and a UUID is typically 8 bytes. How Done -- To view, visit http://gerrit.cloudera.org:8080/15600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf1ccff3dde7ccf54c4c2c6c2910915c69153316 Gerrit-Change-Number: 15600 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Mar 2020 00:00:32 +0000 Gerrit-HasComments: Yes