Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15605 )
Change subject: KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace ...................................................................... KUDU-3093: another band-aid for this DebugUtilTest.TestSignalStackTrace A TSAN build yielded a stack trace like: @ 0x444a88 __tsan::ProcessPendingSignals() @ 0x4541c1 __interceptor_pthread_mutex_trylock @ 0x7fbca26124e1 kudu::Mutex::TryAcquire() @ 0x7fbca2612893 kudu::Mutex::Acquire() @ 0x4fe036 kudu::MutexLock::MutexLock() @ 0x504abd kudu::CountDownLatch::WaitUntil() @ 0x504a5f kudu::CountDownLatch::WaitFor() @ 0x4f04a9 kudu::(anonymous namespace)::SleeperThread() ... Rather than find the synchronization primitive frame least likely to be inlined, let's take a more comprehensive approach and search for multiple candidate frames, including SleeperThread. I tested this locally in DEBUG, RELEASE, ASAN, and TSAN modes. Change-Id: Ia4ca0f48ba1d7ad4cea40b70af271d7948f78a57 Reviewed-on: http://gerrit.cloudera.org:8080/15605 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/util/debug-util-test.cc 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/15605 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia4ca0f48ba1d7ad4cea40b70af271d7948f78a57 Gerrit-Change-Number: 15605 Gerrit-PatchSet: 3 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
