Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15615 )
Change subject: [subprocess] Fix shutdown behavior ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15615/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java File java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java: http://gerrit.cloudera.org:8080/#/c/15615/1/java/kudu-subprocess/src/main/java/org/apache/kudu/subprocess/SubprocessExecutor.java@68 PS1, Line 68: System.exit(1); > If a RuntimeException is thrown and isn't caught, that thread will be stopp If we're calling System.exit(), we don't need to throw a new exception, right? That's effectively dead code. -- To view, visit http://gerrit.cloudera.org:8080/15615 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia84bff891eaff667d7b22e89c66f24980ad76d70 Gerrit-Change-Number: 15615 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 31 Mar 2020 20:22:23 +0000 Gerrit-HasComments: Yes
