Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15647 )
Change subject: bitshuffle: stop using uninitialized data as padding ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15647/2/src/kudu/cfile/bshuf_block.h File src/kudu/cfile/bshuf_block.h: http://gerrit.cloudera.org:8080/#/c/15647/2/src/kudu/cfile/bshuf_block.h@186 PS2, Line 186: > With this fix the data_ buffer will indeed be multiple of 8 unlike earlier kHeaderSize is 20. I presume you mean data_ will be a multiple of 8 _after the padding is added_? As I already merged this patch, I've added the DCHECK in a new commit: http://gerrit.cloudera.org:8080/15652 -- To view, visit http://gerrit.cloudera.org:8080/15647 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25eba027ba356774173b2313c68436d7baddaddc Gerrit-Change-Number: 15647 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 04 Apr 2020 21:39:52 +0000 Gerrit-HasComments: Yes
