Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15650 )
Change subject: ranger: allow overwriting of the log4j2 properties file ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/15650/2/src/kudu/ranger/ranger_client.cc@308 PS2, Line 308: RETURN_NOT_OK(WriteStringToFileSync( : env, subprocess::Log4j2Properties(program_name, FLAGS_log_dir, log_filename, : FLAGS_max_log_size, FLAGS_max_log_files, : FLAGS_ranger_log_level, : FLAGS_ranger_logtostdout), : log4j2_properties_file)); Is it possible that the existing file is read by some actor while being overwritten? If so, maybe replace the file atomically using the temporary file with subsequent move/rename approach? -- To view, visit http://gerrit.cloudera.org:8080/15650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a06f8a1b3328cfd4029295527b5ba61a03efbfa Gerrit-Change-Number: 15650 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 05 Apr 2020 03:13:21 +0000 Gerrit-HasComments: Yes
