Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15042 )
Change subject: cfile: change BlockBuilder API to yield a vector of Slices ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/15042/6/src/kudu/cfile/encoding-test.cc File src/kudu/cfile/encoding-test.cc: http://gerrit.cloudera.org:8080/#/c/15042/6/src/kudu/cfile/encoding-test.cc@367 PS6, Line 367: with unsigned types > nit: Isn't this instantiated by IntEncodingTest with both signed and unsign Aah right. Changed to using C++11 std::is_signed<CppType> instead. No tidy bot warnings. http://gerrit.cloudera.org:8080/#/c/15042/6/src/kudu/cfile/encoding-test.cc@373 PS6, Line 373: char, short > nit: I might be missing something, but isn't this only called with int type It's called with shorter types namely uint8, int16 etc. Updated comment. -- To view, visit http://gerrit.cloudera.org:8080/15042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifc7a5f148a4a43cedac2428f4c1a18d0f93a10db Gerrit-Change-Number: 15042 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 08 Apr 2020 02:01:33 +0000 Gerrit-HasComments: Yes
