Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15681 )
Change subject: KUDU-3078 Add Ranger tests to master_authz-itest ...................................................................... Patch Set 7: (6 comments) http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/integration-tests/master_authz-itest.cc File src/kudu/integration-tests/master_authz-itest.cc: http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/integration-tests/master_authz-itest.cc@443 PS7, Line 443: const uni nit: indent. http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/integration-tests/master_authz-itest.cc@477 PS7, Line 477: policy.tables.emplace_back("*"); This can be removed as only Database level privilege is required. http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/integration-tests/master_authz-itest.cc@491 PS7, Line 491: SleepFor(MonoDelta::FromMilliseconds(1500)) If the sleep is for waiting the polling interval to finish in Ranger client, we can even make it smaller instead of sleep here? http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/integration-tests/master_authz-itest.cc@510 PS7, Line 510: policy_new_table.tables.emplace_back("*") This can be removed. http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/integration-tests/master_authz-itest.cc@540 PS7, Line 540: ParseHiveTableIdentifier We should use ParseRangerTableIdentifier? http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/master/ranger_authz_provider.cc File src/kudu/master/ranger_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/15681/7/src/kudu/master/ranger_authz_provider.cc@199 PS7, Line 199: CHECK_OK(client_.AuthorizeActionMultipleColumns(user, ActionPB::SELECT, table_name, : &column_names)); But the subprocess execution can also return a non OK() status? -- To view, visit http://gerrit.cloudera.org:8080/15681 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25dc67516cd61f0624914989f8db4c4f94d7e3bf Gerrit-Change-Number: 15681 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 08 Apr 2020 22:30:10 +0000 Gerrit-HasComments: Yes
