Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15722 )
Change subject: [cfile] Add SimpleEncodingTraits to remove boiler plate code in type_encodings.cc ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15722/1/src/kudu/cfile/type_encodings.cc File src/kudu/cfile/type_encodings.cc: http://gerrit.cloudera.org:8080/#/c/15722/1/src/kudu/cfile/type_encodings.cc@24 PS1, Line 24: kudu/cfile/binary_dict_block.h Interesting, why IWYU wants to remove these headers? Any idea? http://gerrit.cloudera.org:8080/#/c/15722/1/src/kudu/cfile/type_encodings.cc@56 PS1, Line 56: template<class Builder, class Decoder> nit: add a small doc explaining the essence? http://gerrit.cloudera.org:8080/#/c/15722/1/src/kudu/cfile/type_encodings.cc@57 PS1, Line 57: SimpleEncodingTraits nit: what about renaming 'SimpleEncodingTraits' --> 'EncodingTraits' ? -- To view, visit http://gerrit.cloudera.org:8080/15722 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie01865756713b4a1f75a4e1574080ff892671386 Gerrit-Change-Number: 15722 Gerrit-PatchSet: 1 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 14 Apr 2020 00:00:11 +0000 Gerrit-HasComments: Yes
