Greg Solovyev has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )
Change subject: WIP [docs] Kudu 1.12 release notes draft ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@75 PS5, Line 75: If setting : `--time_source=auto`, Kudu masters and tablet servers use the built-in NTP : client synchronized with dedicated NTP servers available via host-only : network in AWS and GCE cloud environments, otherwise Kudu masters and tablet : servers rely on local machine's clock synchronized by NTP I think this sentence needs to be broken up. E.g.: When the option is set to `--time_source=auto`, Kudu masters and tablet servers use the built-in NTP client. Built-in NTP client is synchronized with dedicated NTP servers available via host-only networks in AWS and GCE cloud environments. When dedicated NTP servers are not available, Kudu masters and tablet servers rely on local machine's clock synchronized by NTP. http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@105 PS5, Line 105: * Kudu tablet servers and masters now expose a metric for the number of tablet should we mention the name of the metric here? Also, I suggest moving this section to be right before or right after the section about metric severity levels. http://gerrit.cloudera.org:8080/#/c/15685/5/docs/release_notes.adoc@118 PS5, Line 118: * The built-in NTP client is now fully supported as the time source for Kudu's I think this section and section about chronyd should be moved up right above the section about --time_source -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Lieber-Dembo <a...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Hannah Nguyen <hannahvnguye...@gmail.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Volodymyr Verovkin <verjov...@cloudera.com> Gerrit-Comment-Date: Wed, 15 Apr 2020 18:56:40 +0000 Gerrit-HasComments: Yes
