Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15685 )
Change subject: [docs] add 1.12.0 release notes ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc@77 PS9, Line 77: is set Style: 'is set' is for binary/boolean flags. Please return back the original wording. Also, this sentence is incorrect: it's not true that if --time_source=auto, then Kudu masters and tablet servers use the built-in NTP client. http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc@78 PS9, Line 78: synchronizes Synchronizes what? http://gerrit.cloudera.org:8080/#/c/15685/9/docs/release_notes.adoc@80 PS9, Line 80: the built-in client relies on the local machine's clock This is incorrect. The built-in NTP client does not rely on the local machine clock. In fact, that's the essence of the built-in NTP client to serve as the source of clock, not relying on the local clock. Why not to use the alternative as suggested by Greg? At least it's semantically correct. -- To view, visit http://gerrit.cloudera.org:8080/15685 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.12.x Gerrit-MessageType: comment Gerrit-Change-Id: I300fb597a4eed36199ebf8760084e6df1fb04e9a Gerrit-Change-Number: 15685 Gerrit-PatchSet: 9 Gerrit-Owner: Hao Hao <[email protected]> Gerrit-Reviewer: Adar Lieber-Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Greg Solovyev <[email protected]> Gerrit-Reviewer: Hannah Nguyen <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Volodymyr Verovkin <[email protected]> Gerrit-Comment-Date: Tue, 21 Apr 2020 21:45:54 +0000 Gerrit-HasComments: Yes
