Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15794 )
Change subject: client: prefer tservers in the same location when multiple are local ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15794/2/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/15794/2/src/kudu/client/client-internal.cc@222 PS2, Line 222: // 1. If there is a replica local to the client according to its IP and : // location, pick it. If there are multiple, pick a random one. : // 2. Otherwise, if there is a replica in the same location, pick it. If : // there are multiple, pick a random one. > I don't understand the difference between local and same location? Location refers to a location assigned by the location-assigning script. "Local" in this context refers to the output of IsTabletServerLocal(), which looks at some host ports https://github.com/apache/kudu/blob/master/src/kudu/client/client-internal.cc#L445 -- To view, visit http://gerrit.cloudera.org:8080/15794 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a0dbac073ba8a9f80a3f175157a09d06037b0df Gerrit-Change-Number: 15794 Gerrit-PatchSet: 2 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 Apr 2020 02:00:30 +0000 Gerrit-HasComments: Yes
