Alexey Serbin has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/15794 )

Change subject: clients: prefer tservers in the same location when multiple are 
local
......................................................................

clients: prefer tservers in the same location when multiple are local

be68ce8 introduced the behavior that mini-servers that are local to a
C++ client are treated as local, even on Linux. As such, a
location-aware mini-cluster would not honor client location awareness,
since all mini-servers would be considered local.

While this surfaced as flakiness of location_awareness-itest, this is an
actual product deficiency, albeit one we don't expect to be very common:
if multiple servers are colocated with a client, and the servers are
assigned different locations, those locations should be honored when
picking tablet servers.

Without this patch, location_assignment-itest is ~24% flaky. With it, it
passed in debug mode 300/300 times.

The same logic is updated in the Java client.

Change-Id: I6a0dbac073ba8a9f80a3f175157a09d06037b0df
Reviewed-on: http://gerrit.cloudera.org:8080/15794
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/RemoteTablet.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRemoteTablet.java
M src/kudu/client/client-internal.cc
M src/kudu/integration-tests/location_assignment-itest.cc
4 files changed, 69 insertions(+), 38 deletions(-)

Approvals:
  Alexey Serbin: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/15794
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a0dbac073ba8a9f80a3f175157a09d06037b0df
Gerrit-Change-Number: 15794
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)

Reply via email to