Grant Henke has uploaded this change for review. ( 
http://gerrit.cloudera.org:8080/15812


Change subject: [binary-jar] Fix macOS binary jar libc++abi error
......................................................................

[binary-jar] Fix macOS binary jar libc++abi error

The macOS binary jar was broken by commit 458e6ce because
thirdparty now builds with libc++abi for normal builds.

This resulted in an error like the below when using a macOS binary jar:
    [main] INFO org.apache.kudu.shaded.com.google.gradle.osdetector.OsDetector 
- os.detected.classifier=osx-x86_64
    [main] INFO org.apache.kudu.test.cluster.KuduBinaryLocator - Using Kudu 
binary jar directory: 
/var/folders/3y/nrs6__c10n107f357n7yx2100000gp/T/kudu-binary-jar6249991106299083358
    [main] INFO org.apache.kudu.test.cluster.MiniKuduCluster - Starting 
process: 
[/var/folders/3y/nrs6__c10n107f357n7yx2100000gp/T/kudu-binary-jar6249991106299083358/kudu-binary-1.12.0-osx-x86_64/bin/kudu,
 test, mini_cluster, --serialization=pb]
    [cluster stderr printer] INFO org.apache.kudu.test.cluster.MiniKuduCluster 
- dyld: Library not loaded: @rpath/libc++abi.1.dylib
    [cluster stderr printer] INFO org.apache.kudu.test.cluster.MiniKuduCluster 
-   Referenced from: 
/private/var/folders/3y/nrs6__c10n107f357n7yx2100000gp/T/kudu-binary-jar6249991106299083358/kudu-binary-1.12.0-osx-x86_64/lib/libglog.0.dylib
    [cluster stderr printer] INFO org.apache.kudu.test.cluster.MiniKuduCluster 
-   Reason: image not found
    [main] ERROR org.apache.kudu.test.junit.RetryRule - 
org.apache.kudu.examples.ExampleTest.testCreateExampleTable: failed attempt 1
    java.io.EOFException

This patch fixes the issue by adjusting the `PAT_MACOS_LIB_EXCLUDE`
regex to ensure the libc++abi library is not excluded from the jar.
Additionaly it adjusts the licence file to include the libc++abi.

Change-Id: I395fd39d62fd7bfcd2aa2b0781d77c3a16e19d4b
---
M build-support/mini-cluster/LICENSE-BINARY-JAR-OSX.txt
M build-support/mini-cluster/relocate_binaries_for_mini_cluster.py
2 files changed, 5 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/15812/1
--
To view, visit http://gerrit.cloudera.org:8080/15812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I395fd39d62fd7bfcd2aa2b0781d77c3a16e19d4b
Gerrit-Change-Number: 15812
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <[email protected]>

Reply via email to