Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15801 )
Change subject: KUDU-2844 (2/3): move RowBlock memory into a new RowBlockMemory struct ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/memrowset-test.cc File src/kudu/tablet/memrowset-test.cc: http://gerrit.cloudera.org:8080/#/c/15801/3/src/kudu/tablet/memrowset-test.cc@216 PS3, Line 216: mem.Reset(); This wasn't necessary, was it? It's just good practice? -- To view, visit http://gerrit.cloudera.org:8080/15801 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I17a21f33f44988795ffe064b3ba41055e1a19e90 Gerrit-Change-Number: 15801 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 01 May 2020 05:33:43 +0000 Gerrit-HasComments: Yes
