Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15804 )
Change subject: Move rowwise serialization to a new .cc file ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/15804/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15804/1//COMMIT_MSG@7 PS1, Line 7: Move rowwise serialization to a new .cc file nit: somewhat obvious, but mind noting that this has no major functional changes? http://gerrit.cloudera.org:8080/#/c/15804/1/src/kudu/common/CMakeLists.txt File src/kudu/common/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/15804/1/src/kudu/common/CMakeLists.txt@58 PS1, Line 58: row_serialization.cc nit: flip with row_operations.cc http://gerrit.cloudera.org:8080/#/c/15804/1/src/kudu/common/wire_protocol-test-util.h File src/kudu/common/wire_protocol-test-util.h: http://gerrit.cloudera.org:8080/#/c/15804/1/src/kudu/common/wire_protocol-test-util.h@102 PS1, Line 102: : : nit: drop extras? -- To view, visit http://gerrit.cloudera.org:8080/15804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6240d38fb6bdee80f5b9041b5ccae3c0257cc09 Gerrit-Change-Number: 15804 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 01 May 2020 06:00:39 +0000 Gerrit-HasComments: Yes
