Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15805 )
Change subject: Refactor rowwise serialization to calculate projection once vs per-batch ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/15805/1/src/kudu/common/row_serialization.h File src/kudu/common/row_serialization.h: http://gerrit.cloudera.org:8080/#/c/15805/1/src/kudu/common/row_serialization.h@19 PS1, Line 19: #include <stddef.h> nit: prefer cstddef in new code http://gerrit.cloudera.org:8080/#/c/15805/1/src/kudu/common/row_serialization.cc File src/kudu/common/row_serialization.cc: http://gerrit.cloudera.org:8080/#/c/15805/1/src/kudu/common/row_serialization.cc@a228 PS1, Line 228: : : Looking at the calls to InitSerializer(), this case no longer seems possible. Is that so? Did the behavior change? http://gerrit.cloudera.org:8080/#/c/15805/1/src/kudu/tserver/tablet_service.cc File src/kudu/tserver/tablet_service.cc: http://gerrit.cloudera.org:8080/#/c/15805/1/src/kudu/tserver/tablet_service.cc@a757 PS1, Line 757: : nit: Hrm, I don't recall the significance of this, and it's not super obvious in the immediately surrounding code. Mind adding a comment in the new code? -- To view, visit http://gerrit.cloudera.org:8080/15805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I583fa02b4ea803ba5a2e1f6401181540ed2e85e9 Gerrit-Change-Number: 15805 Gerrit-PatchSet: 1 Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 01 May 2020 06:58:31 +0000 Gerrit-HasComments: Yes
