RuiChen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/14964 )

Change subject: KUDU-3007. Support building Kudu on aarch64 platform
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/14964/18/java/kudu-client/build.gradle
File java/kudu-client/build.gradle:

http://gerrit.cloudera.org:8080/#/c/14964/18/java/kudu-client/build.gradle@39
PS18, Line 39: testCompile project(":kudu-hive")
> it is not specific for aarch64, I forgot the details of reason, let me try
Like liusheng say, it's not specific for aarch64.
We use following command to run Kudu java tests

    ./gradlew clean test --tests 
org.apache.kudu.test.TestMiniKuduCluster.testHiveMetastoreIntegration

That will cause a ClassNotFound error, because the test case depends on 
mini_hms.cc, and mini_hms.cc depends on hms-plugin.jar, it's a link to point to 
java/kudu-hive/build/libs/kudu-hive.jar, would be deleted when "./gradlew 
clean" executed, So we add an explicit dependence for kudu-client, and 
kudu-test-utils depends on kudu-client, so it worked, we don't add the 
dependence in kudu-test-utils to avoid the cycle dependence between "kudu-hive" 
and "kudu-test-utils".

I saw Kudu master have be updated to use "cp" instead of "ln" for 
hms-plugin.jar 
https://github.com/apache/kudu/blob/master/src/kudu/hms/CMakeLists.txt#L70 , so 
it should not happen in latest master branch. I think it's ok to remove the 
change from aarch64 patchset.



--
To view, visit http://gerrit.cloudera.org:8080/14964
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2953519c5d28de17e6b2bb7094abab0c1cd12c97
Gerrit-Change-Number: 14964
Gerrit-PatchSet: 18
Gerrit-Owner: liusheng <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: RuiChen <[email protected]>
Gerrit-Reviewer: liusheng <[email protected]>
Gerrit-Comment-Date: Wed, 06 May 2020 07:49:47 +0000
Gerrit-HasComments: Yes

Reply via email to