RuiChen has posted comments on this change. ( http://gerrit.cloudera.org:8080/15899 )
Change subject: KUDU-3096: Fix core dump when thread race between GetThreadStack and SuperviseThread ...................................................................... Patch Set 2: > > Patch Set 1: > > > > Todd, thank you for replying to share these information, looks > like two things impact the part of code: 1.libunwind call malloc() > in thread stack trace collection, I find upstream have fixed it in > libunwind 1.4.0 https://github.com/libunwind/libunwind/pull/72 ; > 2.save waiting time for spawning thread. So I update the patch to > address #2, set tid after strings::Substitute that cause coredump > in patchset 2, I think we maybe update libunwind in the future. > > Why not update libunwind now? My point above is that, even if > you've fixed this particular core dump, you still have a potential > deadlock bug because of the call to malloc in libunwind. The libunwind source code package that Kudu depend on is in AWS S3, and I don't know how to push the 1.4.x release into it, so I commit the patch as workaround. Could you help to add a 1.4.x libunwind into S3? then I will update patch to apply it, thanks -- To view, visit http://gerrit.cloudera.org:8080/15899 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icc722cd5e8ed4ed668d279f6ec831e4eeb69f955 Gerrit-Change-Number: 15899 Gerrit-PatchSet: 2 Gerrit-Owner: RuiChen <chenrui.m...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: RuiChen <chenrui.m...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 14 May 2020 09:37:05 +0000 Gerrit-HasComments: No
