Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15913 )
Change subject: [perf] Check range predicate first while evaluating Bloom filter predicate ...................................................................... Patch Set 5: Code-Review+2 (5 comments) http://gerrit.cloudera.org:8080/#/c/15913/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/15913/3//COMMIT_MSG@19 PS3, Line 19: 1M c > nit: 1M here too Done http://gerrit.cloudera.org:8080/#/c/15913/3//COMMIT_MSG@25 PS3, Line 25: > nit: would be nice to describe what these are and why the results look the Done http://gerrit.cloudera.org:8080/#/c/15913/3/src/kudu/client/predicate-test.cc File src/kudu/client/predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/15913/3/src/kudu/client/predicate-test.cc@1305 PS3, Line 1305: CreateRandomUniqueIntegers > Bunch of callers to that function unrelated to this change. Would prefer do Sounds good http://gerrit.cloudera.org:8080/#/c/15913/3/src/kudu/client/predicate-test.cc@1355 PS3, Line 1355: Counting rows with a range predicat > Fixed the log description. OK, though if the goal is to make it easy to find this output when benchmarking, --gtest_filter is probably sufficient since we'd probably only be running the benchmark test. http://gerrit.cloudera.org:8080/#/c/15913/3/src/kudu/client/predicate-test.cc@1471 PS3, Line 1471: KuduColumnSchema::VARCH > NewInBloomFilterPredicate() takes ownership of the predicate. Ack -- To view, visit http://gerrit.cloudera.org:8080/15913 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8451d6ddfe1fbdf307b3e9f2cc23a8d06e655ba3 Gerrit-Change-Number: 15913 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 15 May 2020 19:08:08 +0000 Gerrit-HasComments: Yes
