Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15928 )
Change subject: docs: update the steps to update directories ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1176 PS1, Line 1176: Be sure to use nit: too many 'sure' :) Maybe, simply Use `ksck` to ensure ... http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1184 PS1, Line 1184: the following steps Not sure I see the advertised steps below. I see below goes the list of NOTES, and then comes one bullet point about the requirement to keep tablet server shutdown when running the tool. http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1208 PS1, Line 1208: The tool itself runs quickly, so this offline : window should be brief, and as such Not a part of this exact patch, but I'm not sure how much useful information this provides to the users. For example, how long 'brief' is in this case (seconds, minutes, hours)? Does it depend on the amount of data under the data directories? Maybe, drop this piece of mention what tools does to provide the idea how brief the maintenance window could be. http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224 PS1, Line 1224: values value ? http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224 PS1, Line 1224: sever server ? http://gerrit.cloudera.org:8080/#/c/15928/1/docs/administration.adoc@1224 PS1, Line 1224: flags nit: flag ? -- To view, visit http://gerrit.cloudera.org:8080/15928 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b5f8b6ca548dd34cc866c338ca3b233da472e11 Gerrit-Change-Number: 15928 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 16 May 2020 18:14:59 +0000 Gerrit-HasComments: Yes
