Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15927 )
Change subject: KUDU-2817: Upgrade snappy to 1.1.8 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/15927/2/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/15927/2/thirdparty/build-definitions.sh@528 PS2, Line 528: -DSNAPPY_BUILD_TESTS=OFF > Just curious: whether it's because it's not compiling or this is to save so I saw a TSAN instrumentation issue in the test code, but ideally we should disable building tests in thirdparty anyway. -- To view, visit http://gerrit.cloudera.org:8080/15927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I19e4eda122c0ea957bbe504fc7de681bb72068cd Gerrit-Change-Number: 15927 Gerrit-PatchSet: 3 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 18 May 2020 21:00:37 +0000 Gerrit-HasComments: Yes
