Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15957
Change subject: [thirdparty] Fix Snappy build to add -fPIC ...................................................................... [thirdparty] Fix Snappy build to add -fPIC When upgrading Snappy in https://gerrit.cloudera.org/#/c/15927/ I accidentally removed the --with-pic option when converting the build from autoconf to cmake. This caused issues in some build environments such as: 21:34:13 /usr/bin/ld: ../../../../../thirdparty/installed/uninstrumented/lib/libsnappy.a(snappy-sinksource.cc.o): relocation R_X86_64_32S against `_ZTVN6snappy6SourceE' can not be used when making a shared object; recompile with -fPIC 21:34:13 ../../../../../thirdparty/installed/uninstrumented/lib/libsnappy.a: error adding symbols: Bad value 21:34:13 collect2: error: ld returned 1 exit status This patch fixes this by adding back -fPIC to the CFLAGS and CXXFLAGS similar to other cmake builds in thirdparty. Change-Id: I48452275c052c9bf54845604fad2deeb002ae0d0 --- M thirdparty/build-definitions.sh 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/57/15957/1 -- To view, visit http://gerrit.cloudera.org:8080/15957 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I48452275c052c9bf54845604fad2deeb002ae0d0 Gerrit-Change-Number: 15957 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org>
